Fixes #3144 RenamePropertyKey and ChangePropertyValue running together #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing together don't work as expected
ge0ffrey
commented
May 10, 2023
| @@ -73,6 +73,7 @@ public Xml.Tag visitTag(Xml.Tag tag, ExecutionContext ctx) { | |||
| Xml.Tag t = super.visitTag(tag, ctx); | |||
| if (isPropertyTag() && oldKey.equals(t.getName())) { | |||
| t = t.withName(newKey); | |||
| maybeUpdateModel(); | |||
There was a problem hiding this comment.
I verified that adding this change fixes the issue, by using local SNAPSHOT builds (and without it, the issue reproduces). See screenshots above.
But... the test below seems to NOT fail if this line isn't there (TDD:it should fail if the test environment matches a real environment).
rpau
reviewed
May 10, 2023
rewrite-maven/src/test/java/org/openrewrite/maven/RenamePropertyKeyTest.java
Outdated
Show resolved
Hide resolved
ge0ffrey
commented
May 10, 2023
rewrite-maven/src/test/java/org/openrewrite/maven/RenamePropertyKeyTest.java
Outdated
Show resolved
Hide resolved
rpau
approved these changes
May 10, 2023
|
Thanks @ge0ffrey ! Hope this helps drive the TimeFold adoption. :) |
|
@timtebeek I am sure it will :) It makes upgrading easier. Thanks Tim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR (INCORRECT):
With this PR (CORRECT):
