Fix parsing of nested generics in Groovy (#4707)

* Fix parsing of nested generics in Groovy Fixes: #4702 * Polish
openrewrite · Nov 23, 2024 · dcc0ec6 · dcc0ec6
1 parent 2b76e9c
commit dcc0ec6
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 12 deletions.
diff --git a/rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java b/rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java
@@ -2585,7 +2585,7 @@ private Expression visitTypeParameterization(GenericsType genericsType) {
             return new J.Empty(randomId(), prefix, Markers.EMPTY);
         }
         cursor = saveCursor;
-        return typeTree(null)
+        return typeTree(genericsType.getType())
                 .withType(typeMapping.type(genericsType));
     }
 

diff --git a/rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/BinaryTest.java b/rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/BinaryTest.java
@@ -207,18 +207,18 @@ void stringMultipliedInParentheses() {
     void extraParensAroundInfixOperator() {
         rewriteRun(
           groovy(
-                """
-            def foo(Map map) {
-                ((map.containsKey("foo"))
-                        && ((map.get("foo")).equals("bar")))
-            }
-            def timestamp(int hours, int minutes, int seconds) {
-                (hours) * 60 * 60 + (minutes * 60) + seconds
-            }
-            def differenceInDays(int time) {
-                return (int) ((time)/(1000*60*60*24))
-            }
             """
+              def foo(Map map) {
+                  ((map.containsKey("foo"))
+                          && ((map.get("foo")).equals("bar")))
+              }
+              def timestamp(int hours, int minutes, int seconds) {
+                  (hours) * 60 * 60 + (minutes * 60) + seconds
+              }
+              def differenceInDays(int time) {
+                  return (int) ((time)/(1000*60*60*24))
+              }
+              """
           )
         );
     }

diff --git a/rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/VariableDeclarationsTest.java b/rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/VariableDeclarationsTest.java
@@ -49,6 +49,13 @@ void finalKeyword() {
         );
     }
 
+    @Test
+    void nestedGenerics() {
+        rewriteRun(
+          groovy("final map = new HashMap<String, List<String>>()")
+        );
+    }
+
     @Test
     void singleVariableDeclaration() {
         rewriteRun(