Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't exclude junit4 for testcontainers jupiter #641

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Nov 17, 2024

What's changed?

JUnit5 migration recipe

What's your motivation?

I have an application that uses Testcontainers junit-jupiter

We don't want to exclude JUnit4 because Testcontainers needs it.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've turned it into a wildcard for simplicity; Let's hope they get around to removing the dependency.

@timtebeek timtebeek merged commit 5091a38 into openrewrite:main Nov 17, 2024
2 checks passed
@sullis sullis deleted the sean/dont-exclude-junit4 branch November 18, 2024 03:51
@wakingrufus
Copy link
Contributor

Here is the upstream issue: testcontainers/testcontainers-java#970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants