Support sources located in an unnamed package #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
commented
Jan 10, 2024
| @@ -306,12 +309,15 @@ public void visitClassDef(JCTree.JCClassDecl classDecl) { | |||
| if (classDecl.sym != null && classDecl.sym.getNestingKind() == NestingKind.TOP_LEVEL && !recipes.isEmpty()) { | |||
| boolean outerClassRequired = descriptor == null; | |||
| try { | |||
| Symbol.PackageSymbol pkg = classDecl.sym.packge(); | |||
There was a problem hiding this comment.
Deduplicating classDecl.sym.packge() and classDecl.sym.fullname.toString() at the top of this method would yield an NPE, unless more things are refactored. But that would likely change the indentation of most of the code in this method, which would make the PR way harder to review. Seems better to refactor that separately (if at all).
timtebeek
approved these changes
Jan 10, 2024
|
Force-pushed to fix the license violation. (Didn't notice the review; sorry!) |
|
All good! Released v1.4.2 just now. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PicnicSupermarket/error-prone-support#775 (comment) and subsequent analysis.
Besides the new unit tests, I also verified that this change resolves the issue in the aforementioned Error Prone Support PR.