Support Arrays and ignore if statements #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstreef
approved these changes
Dec 27, 2023
|
|
||
| /** | ||
| * @param message The message to print | ||
| * @param symbol The symbol to attach the message to; printed as clickable link to file | ||
| */ | ||
| private void printNoteOnce(String message, Symbol.ClassSymbol symbol) { | ||
| if (printedMessages.add(message)) { | ||
| if (printedMessages.compute(message, (k, v) -> v == null ? 1 : v + 1) == 1) { |
There was a problem hiding this comment.
why this change? Is this somehow more performant?
There was a problem hiding this comment.
It's to allow one to inspect the number of times recipes are excluded, as used in this #47 (comment)
Didn't want to make that part of the standard output though; I think once and linked to the source is enough, as opposed to just a summary of how often there are exclusions not tied to a particular instance. Having this counter allows us to easily print it as a one off though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #53 for easier review and to minimize diff.