Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate default constructor with JavaDoc for Xdoclint #50

Merged
merged 6 commits into from
Dec 17, 2023
Merged

Generate default constructor with JavaDoc for Xdoclint #50

merged 6 commits into from
Dec 17, 2023

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 17, 2023
@timtebeek timtebeek self-assigned this Dec 17, 2023
Stephan202
Stephan202 reviewed Dec 17, 2023
View reviewed changes
Copy link
Contributor

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left two comments about possible further "roadblocks", but if you already tested this against the other repo: LGTM!

src/test/resources/template/ParameterReuseRecipe$1_before.java Outdated Show resolved Hide resolved
src/test/resources/template/ParameterReuseRecipe$1_before.java Outdated Show resolved Hide resolved
src/test/resources/template/ParameterReuseRecipe$1_before.java Outdated Show resolved Hide resolved
@timtebeek
Copy link
Contributor Author

We need the same documented default constructor still for RefasterTemplateProcessor generated Recipe & Recipes.

Stephan202
Stephan202 reviewed Dec 17, 2023
View reviewed changes
Copy link
Contributor

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thought; up to you :)

src/test/resources/template/ParameterReuseRecipe$1_before.java Outdated Show resolved Hide resolved
@timtebeek timtebeek merged commit 25c979f into main Dec 17, 2023
1 check passed
@timtebeek timtebeek deleted the appease-java21-Xdoclint-all branch December 17, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@knutwannheden knutwannheden Awaiting requested review from knutwannheden

Assignees

@timtebeek timtebeek

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtebeek @Stephan202