Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore public modifiers with javadoc #46

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented Dec 17, 2023

What's changed?

  • Resttore public modifiers for template classes, as needed on Java 11+
  • Add JavaDoc on template classes, to reduce warnings on error-prone- support
  • Always print clickable link with notes

Before

[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSortedMapRules.java:[24,16] Generics are currently not supported
[INFO] com.google.errorprone.refaster.Refaster is not supported
[INFO] The @UseImportPolicy is currently not supported
[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/LongStreamRules.java:[66,25] The @Placeholder is currently not supported
[INFO] The @AlsoNegation is currently not supported
[INFO] The @DoNotCall is currently not supported
[INFO] The @Repeated annotation is currently not supported
[INFO] The @Matches annotation is currently not supported

After

[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSortedMapRules.java:[24,16] Generics are currently not supported
[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/EqualityRules.java:[85,16] com.google.errorprone.refaster.Refaster is currently not supported
[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java:[26,16] @UseImportPolicy is currently not supported
[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/LongStreamRules.java:[64,19] @Placeholder is currently not supported
[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/BigDecimalRules.java:[72,16] @AlsoNegation is currently not supported
[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/TestNGToAssertJRules.java:[80,16] @DoNotCall is currently not supported
[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/WebClientRules.java:[179,16] @Repeated is currently not supported
[INFO] /error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java:[1585,16] @Matches is currently not supported

What's your motivation?

Makes things work on Java 11 and in error-prone-support

@timtebeek timtebeek self-assigned this Dec 17, 2023
@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Dec 17, 2023
@timtebeek timtebeek marked this pull request as ready for review December 17, 2023 13:13
@timtebeek timtebeek merged commit e141e81 into main Dec 17, 2023
1 check passed
@timtebeek timtebeek deleted the restore-public-modifiers-with-javadoc branch December 17, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant