Call ShortenFullyQualifiedTypeReferences after visit

[timtebeek]

What's changed?

We now call doAfterVisit(new ShortenFullyQualifiedTypeReferences().getVisitor()) from within the if statement.

What's your motivation?

I think this is what we discussed, such that templates can use fully qualified references for convenience, yet insert shortened references in practice.

Anything in particular you'd like reviewers to focus on?

Did you indeed intend to call the visitor like this, or in a more targeted way?

Anyone you would like to review specifically?

@knutwannheden

Have you considered any alternatives or workarounds?

Not sure if there's any other ways we might want to explore.

Any additional context

This ought to help PRs such as this on

• Plexus FileUtils refaster template recipes rewrite-migrate-java#272

[knutwannheden]

I think adding the ShortenFullyQualifiedTypeReferences recipe on its own is not very interesting. We should IMHO change the template generation code so that it only produces fully qualified references to types and static members. But this will be more work, as I think I remember that the Refaster processor currently lets the other annotation processor generate the template code. Possibly we should for more flexibility instead inline it into the Refaster processor.

[timtebeek]

As discussed over on openrewrite/rewrite-migrate-java#272 (comment)