Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Preconditions of overloaded @BeforeTemplate methods are filtered away #123

Conversation

jevanlingen
Copy link
Contributor

What's changed?

After

we should be able to create fitting preconditions with multiple @BeforeTemplates (so no breaking UsesType when not all @BeforeTemplate use that type, as mentioned in #119). But the code did not work for overloaded methods, because the key/value in a temporary precondition-map was replaced by the next overloaded method.

What's your motivation?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jevanlingen jevanlingen added the bug Something isn't working label Dec 20, 2024
@jevanlingen jevanlingen self-assigned this Dec 20, 2024
@timtebeek timtebeek merged commit e2336a8 into main Dec 20, 2024
2 checks passed
@timtebeek timtebeek deleted the bugfix-preconditions-of-overloaded-before-template-methods-are-filtered-away branch December 20, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants