Match method overrides in precondition #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Instead of
new UsesMethod<>("java.lang.String join(..)")Generate
new UsesMethod<>("java.lang.String join(..)", true)What's your motivation?
We want to also match methods overrridden in sub classes where possible.
Anything in particular you'd like reviewers to focus on?
Not sure if this might negatively affect some existing recipes that have come to expect stricter matching.
Figured open this PR to get the discussion around that going.
Also not yet sure if the
before.matcher(getCursor())).find()would even match.Anyone you would like to review specifically?
@knutwannheden
Have you considered any alternatives or workarounds?
We could add explicit recipes for overridden methods, but that quickly explodes the number of recipes.
We could also offer a way to tag before templates where overridden methods should also be matched.
Any additional context
Came up while discussing recipes for Apache POI, where
Cellmight have multiple extending classes.