-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support Refaster templates which use lambdas (#111)
This still doesn't allow a template to directly return a lambda, because the `JavaTemplate` doesn't capture the lambda's type in any way, but at least a template can still use a lambda (e.g. as a method argument).
- Loading branch information
1 parent
2937038
commit e1eabde
Showing
5 changed files
with
183 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright 2024 the original author or authors. | ||
* <p> | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* <p> | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* <p> | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package foo; | ||
|
||
import com.google.errorprone.refaster.annotation.AfterTemplate; | ||
import com.google.errorprone.refaster.annotation.BeforeTemplate; | ||
import org.openrewrite.java.template.Matches; | ||
import org.openrewrite.java.template.MethodInvocationMatcher; | ||
import org.openrewrite.java.template.NotMatches; | ||
import org.openrewrite.java.template.RecipeDescriptor; | ||
|
||
import java.util.Comparator; | ||
import java.util.List; | ||
|
||
public class Lambdas { | ||
|
||
public static class UsedLambda { | ||
@BeforeTemplate | ||
void before(List<Integer> is) { | ||
is.sort((x, y) -> x - y); | ||
} | ||
|
||
@AfterTemplate | ||
void after(List<Integer> is) { | ||
is.sort(Comparator.comparingInt(x -> x)); | ||
} | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
/* | ||
* Copyright 2024 the original author or authors. | ||
* <p> | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* <p> | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* <p> | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package foo; | ||
|
||
import org.jspecify.annotations.NullMarked; | ||
import org.openrewrite.ExecutionContext; | ||
import org.openrewrite.Preconditions; | ||
import org.openrewrite.Recipe; | ||
import org.openrewrite.TreeVisitor; | ||
import org.openrewrite.java.JavaParser; | ||
import org.openrewrite.java.JavaTemplate; | ||
import org.openrewrite.java.JavaVisitor; | ||
import org.openrewrite.java.search.*; | ||
import org.openrewrite.java.template.Primitive; | ||
import org.openrewrite.java.template.function.*; | ||
import org.openrewrite.java.template.internal.AbstractRefasterJavaVisitor; | ||
import org.openrewrite.java.tree.*; | ||
|
||
import javax.annotation.Generated; | ||
import java.util.*; | ||
|
||
import static org.openrewrite.java.template.internal.AbstractRefasterJavaVisitor.EmbeddingOption.*; | ||
|
||
/** | ||
* OpenRewrite recipes created for Refaster template {@code foo.Lambdas}. | ||
*/ | ||
@SuppressWarnings("all") | ||
@Generated("org.openrewrite.java.template.processor.RefasterTemplateProcessor") | ||
public class LambdasRecipes extends Recipe { | ||
/** | ||
* Instantiates a new instance. | ||
*/ | ||
public LambdasRecipes() {} | ||
|
||
@Override | ||
public String getDisplayName() { | ||
return "`Lambdas` Refaster recipes"; | ||
} | ||
|
||
@Override | ||
public String getDescription() { | ||
return "Refaster template recipes for `foo.Lambdas`."; | ||
} | ||
|
||
@Override | ||
public List<Recipe> getRecipeList() { | ||
return Arrays.asList( | ||
new UsedLambdaRecipe() | ||
); | ||
} | ||
|
||
/** | ||
* OpenRewrite recipe created for Refaster template {@code Lambdas.UsedLambda}. | ||
*/ | ||
@SuppressWarnings("all") | ||
@NullMarked | ||
@Generated("org.openrewrite.java.template.processor.RefasterTemplateProcessor") | ||
public static class UsedLambdaRecipe extends Recipe { | ||
|
||
/** | ||
* Instantiates a new instance. | ||
*/ | ||
public UsedLambdaRecipe() {} | ||
|
||
@Override | ||
public String getDisplayName() { | ||
return "Refaster template `Lambdas.UsedLambda`"; | ||
} | ||
|
||
@Override | ||
public String getDescription() { | ||
return "Recipe created for the following Refaster template:\n```java\npublic static class UsedLambda {\n \n @BeforeTemplate()\n void before(List<Integer> is) {\n is.sort((x,y)->x - y);\n }\n \n @AfterTemplate()\n void after(List<Integer> is) {\n is.sort(Comparator.comparingInt((x)->x));\n }\n}\n```\n."; | ||
} | ||
|
||
@Override | ||
public TreeVisitor<?, ExecutionContext> getVisitor() { | ||
JavaVisitor<ExecutionContext> javaVisitor = new AbstractRefasterJavaVisitor() { | ||
final JavaTemplate before = JavaTemplate | ||
.builder("#{is:any(java.util.List<java.lang.Integer>)}.sort((x,y)->x - y);") | ||
.build(); | ||
final JavaTemplate after = JavaTemplate | ||
.builder("#{is:any(java.util.List<java.lang.Integer>)}.sort(java.util.Comparator.comparingInt((x)->x));") | ||
.build(); | ||
|
||
@Override | ||
public J visitMethodInvocation(J.MethodInvocation elem, ExecutionContext ctx) { | ||
JavaTemplate.Matcher matcher; | ||
if ((matcher = before.matcher(getCursor())).find()) { | ||
return embed( | ||
after.apply(getCursor(), elem.getCoordinates().replace(), matcher.parameter(0)), | ||
getCursor(), | ||
ctx, | ||
SHORTEN_NAMES | ||
); | ||
} | ||
return super.visitMethodInvocation(elem, ctx); | ||
} | ||
|
||
}; | ||
return Preconditions.check( | ||
Preconditions.and( | ||
new UsesType<>("java.util.List", true), | ||
new UsesMethod<>("java.util.List sort(..)", true) | ||
), | ||
javaVisitor | ||
); | ||
} | ||
} | ||
|
||
} |