Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Remove
RemoveMethodInvocationsVisitor
and update theRemoveUnneededAssertion
recipe as it did use that vistor.What's your motivation?
As the core's
RemoveMethodInvocationsVisitor
recipe can now also remove static methods (openrewrite/rewrite#4754), there is not need for the RemoveMethodCallVisitor anymore.Any additional context
I went a little overboard with improving the
RemoveUnneededAssertion
recipe. I did not only replace the remove-method-invocation visitors, but also rewrote most of the other stuff. It used it's own form of TriFunction (called aInvokeRemoveMethodCallVisitor
), which made the code a little hard to get. I reverted it to a native method, which is more in line with the rest of the code we tend to write.Checklist