EqualsAvoidsNull should flip arguments for constants
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 24, 2024 18:12
…ethodArgs # Conflicts: # src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNullVisitor.java
timtebeek
reviewed
Nov 28, 2024
src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNullVisitor.java
Outdated
Show resolved
Hide resolved
timtebeek
changed the title
EqualsAvoidsNull should flip arguments for constants
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
timtebeek
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Thanks for the help here @punkratz312 ! Nice to see these cases covered as well.
|
wow so quick 🥇 well done 🍀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I might have found an issue in my local project where around 90 violations flagged by PMD are not being replaced correctly. Some of these violations seem related to a list and method arguments.
Could you please take over and enable the necessary tests to confirm if this is indeed an issue?
Thanks in advance!
@timtebeek
@knutwannheden
@ggerbaud