Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow removal of unused local variables with side effects in initializer #378

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Allow removal of unused local variables with side effects in initializer #378

merged 1 commit into from
Oct 23, 2024

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek self-assigned this Oct 23, 2024
@timtebeek timtebeek added the enhancement New feature or request label Oct 23, 2024
@timtebeek timtebeek mentioned this pull request Oct 23, 2024
Merged
github-actions[bot]
github-actions bot reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/staticanalysis/ChainStringBuilderAppendCalls.java
    • lines 36-38

@timtebeek timtebeek merged commit 75f9cc5 into main Oct 23, 2024
2 checks passed
@timtebeek timtebeek deleted the allow-removal-of-unused-local-variables-with-side-effects branch October 23, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@kavitha186 kavitha186 kavitha186 approved these changes

Assignees

@timtebeek timtebeek

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtebeek @kavitha186