InlineOneTimeUsageVariable #367
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@punkratz312 this PR is still marked as draft; when would you say it's ready for review? |
6 tasks
|
Had another look; for now this seems a direct copy of InlineVariable; I assume there's plans to expand the coverage, and we can then decide if that best fits a separate recipe or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is already in place, and the rest is history. Since the implementation is very similar to the template it was derived from, the main issue lies in scoping. The logic for resolving and handling unused (one-time) variables needs to be altered to extend the existing rule found in InlineVariable. This change is necessary to ensure that the rule identifies all unused variables, not just those that are used in return or throw statements.