Duplicate variable name in if statement with two different instanceof

[KoTurk]

Added failing JUnit test for issue "Duplicate variable name in if statement with two different instanceof"

What's changed?

Created a failing JUnit test for the issue.
TODO: fix the issue

What's your motivation?

• InstanceOfPatternMatch leads to duplicate variable name in if statement with two different instanceof #174

Anything in particular you'd like reviewers to focus on?

Be kind, it's my first contribution to Open Source :-)

Anyone you would like to review specifically?

@timtebeek

Checklist

• I've added unit tests to cover both positive and negative cases
• I've added the license header to any new files through ./gradlew licenseFormat
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

As a next step it looks like we should be using VariableNameUtils when naming primitves as well; we already use it elsewhere, but not yet for primitives.

rewrite-static-analysis/src/main/java/org/openrewrite/staticanalysis/InstanceOfPatternMatch.java

Lines 424 to 426 in 2fb2bfb

	} else if (type instanceof JavaType.Primitive) {
	String keyword = ((JavaType.Primitive) type).getKeyword();
	return style == Style.SHORT ? keyword.substring(0, 1) : keyword;

Then, depending on what names VariableNameUtils will produce, we might need to revisit the expected test outcome.

[timtebeek]

Stepped through this case with the debugger; the problem here seems to be that once we process the second instanceof, that we don't have the first instanceof new string variable in scope as we generate a name for the second one. 🤔

[timtebeek]

Exploring a likely fix in

• Detect instanceof pattern variables in scope rewrite#4066

[timtebeek]

Thanks for adding the tests @KoTurk & exploring a fix. Was a more of a puzzle than anticipated, but this current iteration already improves things enough to warrant a merge. There's still a known case uncovered, but I'll stop here for today.