Fix check order of if statement

openrewrite · Oct 5, 2024 · 7bffbca · 7bffbca
1 parent 771e21d
commit 7bffbca
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/main/java/org/openrewrite/staticanalysis/CatchClauseOnlyRethrows.java b/src/main/java/org/openrewrite/staticanalysis/CatchClauseOnlyRethrows.java
@@ -77,7 +77,10 @@ public J.Try visitTry(J.Try tryable, ExecutionContext ctx) {
                         // keep this one
                         for (int j = i + 1; j < tryable.getCatches().size(); j++) {
                             J.Try.Catch next = tryable.getCatches().get(j);
-                            if (!onlyRethrows(next) && hasWiderExceptionType(aCatch, next)) {
+                            if (hasWiderExceptionType(aCatch, next)) {
+                                if (onlyRethrows(next)) {
+                                    return null;
+                                }
                                 return aCatch;
                             }
                         }