Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proprietary modules from BOM #36

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Remove proprietary modules from BOM #36

merged 1 commit into from
Jan 14, 2025

Conversation

timtebeek
Copy link
Contributor

What's your motivation?

These will move to a moderne-recipe-bom to indicate there's a different license that applies to these modules.

@timtebeek timtebeek added the enhancement New feature or request label Jan 14, 2025
@timtebeek timtebeek requested a review from sambsnyd January 14, 2025 19:40
@timtebeek timtebeek self-assigned this Jan 14, 2025
@timtebeek timtebeek merged commit 4416cc6 into main Jan 14, 2025
1 of 2 checks passed
@timtebeek timtebeek deleted the remove-proprietary-modules branch January 14, 2025 20:58
@nmck257
Copy link
Contributor

nmck257 commented Jan 15, 2025 •
edited
Loading

reviewing the resultant BOM (./gradlew dependencies), I see the following paths still exist from this BOM to proprietary artifacts:

  • rewrite-migrate-java (MSAL) -> rewrite-github-actions (MPL)
  • rewrite-recommendations (ALV2) -> rewrite-terraform (MPL)
  • rewrite-spring (MSAL) -> rewrite-reactive-streams (MPL)

@timtebeek timtebeek mentioned this pull request Jan 16, 2025
Merged
timtebeek added a commit to openrewrite/rewrite-spring that referenced this pull request Jan 16, 2025
@timtebeek
Drop reactive streams recipes
c3e95af 
For openrewrite/rewrite-recipe-bom#36 (comment)
@timtebeek timtebeek mentioned this pull request Jan 16, 2025
Merged
timtebeek added a commit to openrewrite/rewrite-spring that referenced this pull request Jan 16, 2025
@timtebeek
Drop reactive streams recipes (#670)
6848a7f 
For openrewrite/rewrite-recipe-bom#36 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmck257 nmck257 nmck257 approved these changes

@sambsnyd sambsnyd Awaiting requested review from sambsnyd

Assignees

@timtebeek timtebeek

Labels
enhancement New feature or request
Projects
OpenRewrite
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtebeek @nmck257