-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from poetry
to uv
#105
Conversation
requires-python = ">=3.12, <4" | ||
|
||
[tool.poetry.dependencies] | ||
python = ">=3.9" | ||
pytest = "^8.3.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were standardizing around 3.9 for some reason that now escapes me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I accidentally used 3.12 API to parse f-strings. As soon as we have a customer requiring an older Python interpreter, I will try to fix that.
I am running into name space collisions when running test because rewrite module is overloaded:
If I change the imports to rewrite_remote and link to my local project then tests go form 60 errors (imports) to 1 error (unrelated to imports) |
Would this workflow need to be changed as well? rewrite-python/.github/workflows/ci.yml Line 45 in 8ec4473
|
Tests actually passed for me, but the IDE displays errors on imports, which I don't understand. |
No description provided.