Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MigrateApiImplicitParam syntax error when args after schema #29

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

SiBorea
Copy link
Contributor

@SiBorea SiBorea commented Jan 15, 2025

What's changed?

Fix MigrateApiImplicitParam syntax error when args after schema.
For example, in UT, example is after dataTypeClass(will be migrated to schema), the recipe will produce syntax error.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this edge case covered as well! :)

Have you ever considered or explored the Moderne toolset to verify recipes at scale? We have an IntelliJ plugin that allows you to run your recipe from your IDE in seconds across dozens of projects. Perhaps that could help you there to pull forward this type of feedback.
https://plugins.jetbrains.com/plugin/17565-moderne

@timtebeek timtebeek merged commit 913c9a2 into openrewrite:main Jan 15, 2025
2 checks passed
@timtebeek timtebeek added the bug Something isn't working label Jan 15, 2025
@SiBorea
Copy link
Contributor Author

SiBorea commented Jan 16, 2025

No, we have an internal toolset to verify recipes on apps. And our company doesn't purchase the business license of IntelliJ for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants