Migrate @SwaggerDefinition to @OpenAPIDefinition #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
src/main/java/org/openrewrite/openapi/swagger/MigrateSwaggerDefinitionToOpenAPIDefinition.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/openapi/swagger/SwaggerToOpenAPITest.java
Outdated
Show resolved
Hide resolved
SiBorea
commented
Dec 4, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
timtebeek
reviewed
Dec 9, 2024
| String servers = ""; | ||
| if (basePath != null && host != null && schemes != null) { | ||
| tpl.append("servers = {\n"); | ||
| for (Expression scheme : ((J.NewArray) schemes).getInitializer()) { |
There was a problem hiding this comment.
If folks use schemes = SwaggerDefinition.Scheme.HTTPS then this throws a class cast exception:
Caused by: java.lang.ClassCastException: class org.openrewrite.java.tree.J$FieldAccess cannot be cast to class org.openrewrite.java.tree.J$NewArray (org.openrewrite.java.tree.J$FieldAccess and org.openrewrite.java.tree.J$NewArray are in unnamed module of loader 'app')
at org.openrewrite.openapi.swagger.MigrateSwaggerDefinitionToOpenAPIDefinition$1.visitAnnotation(MigrateSwaggerDefinitionToOpenAPIDefinition.java:75)
at org.openrewrite.openapi.swagger.MigrateSwaggerDefinitionToOpenAPIDefinition$1.visitAnnotation(MigrateSwaggerDefinitionToOpenAPIDefinition.java:55)
at org.openrewrite.java.tree.J$Annotation.acceptJava(J.java:233)
at org.openrewrite.java.tree.J.accept(J.java:59)
at org.openrewrite.TreeVisitor.visit(TreeVisitor.java:250)
I think that's common enough to warrant proper handling here.
3 tasks
SiBorea
force-pushed
the
swaggerdefinition
branch
from
e7f0f89 to
b2444bc
Compare
src/main/java/org/openrewrite/openapi/swagger/AnnotationUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/openapi/swagger/MigrateSwaggerDefinitionToOpenAPIDefinition.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/openapi/swagger/MigrateSwaggerDefinitionToOpenAPIDefinition.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/openapi/swagger/SwaggerToOpenAPITest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This recipe migrate
@SwaggerDefinitionto@OpenAPIDefinitionbasePath,hostandschemesintoserversconsumesandproduces, leave the others untouchedio.swagger.annotations.Infotoio.swagger.v3.oas.annotations.info.InfoRef: https://support.intershop.com/kb/index.php/Display/2914L4
Checklist