Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate @ApiModelProperty(dataType=) to @Schema(type=) #24

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Migrate @ApiModelProperty(dataType=) to @Schema(type=) #24

merged 1 commit into from
Dec 3, 2024

Conversation

SiBorea
Copy link
Contributor

@SiBorea SiBorea commented Dec 3, 2024

What's changed?

MigrateApiModelPropertyToSchema doesn't handle the case that @ApiModelProperty(dataType="foo"). I convert it to type in this PR. Supposing the better idea is to remove dataType directly.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek merged commit c11e0bc into openrewrite:main Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SiBorea @timtebeek