MigrateApiModelToSchema #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MigrateApiModelToSchema, position removal from ApiModelProperty
|
@timtebeek hello. Are any changes to the code required? |
timtebeek
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Looks great, thanks @OlegZavrazhin ! I'd been traveling hence the delay in review and merge. This should make it into Wednesday's release. :)
Absolutely! You can follow along to this workshop to get started with your own custom in house recipe library. Anything you think could benefit others we'd love to adopt & support going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MigrateApiModelToSchema, position removal from ApiModelProperty
What's changed?
I added
MigrateApiModelToSchema. Also adjustedpositionattribute removal fromApiPropertyModelWhat's your motivation?
I encountered difficulties during migration applying rewrite-openapi
Anything in particular you'd like reviewers to focus on?
There may be something that doesn't match your guidelines, please let me know if you need to change anything.
Have you considered any alternatives or workarounds?
I'd like to know if there is possibility to create and run your own recipes.
Checklist