-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace com.sun.xml.internal.bind.* packages with com.sun.xml.bind.* packages #508
Replace com.sun.xml.internal.bind.* packages with com.sun.xml.bind.* packages #508
Conversation
It is not part of my latest commit
There seem to be some conflicts and unintended changes in this PR; would you mind rebasing or resolving the conflicts? |
src/test/java/org/openrewrite/java/migrate/InternalBindPackages.java
Outdated
Show resolved
Hide resolved
…s.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BhavanaPidapa ! I've pushed a few minor changes, but otherwise good to go.
src/test/java/org/openrewrite/java/migrate/InternalBindPackages.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After spotting some last minute duplication I've now replaced the old specific recipe we had for a single class with the generic ChangePackage recipe added here.
What's changed?
What's your motivation?
I used org.openrewrite.java.ChangePackage for the recipe InternalBindPackages
Anyone you would like to review specifically?
@timtebeek @cjobinabo
Checklist