Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace com.sun.xml.internal.bind.* packages with com.sun.xml.bind.* packages #508

Merged
merged 10 commits into from
Jul 12, 2024

Conversation

BhavanaPidapa
Copy link
Contributor

What's changed?

image

What's your motivation?

I used org.openrewrite.java.ChangePackage for the recipe InternalBindPackages

Anyone you would like to review specifically?

@timtebeek @cjobinabo

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Contributor

There seem to be some conflicts and unintended changes in this PR; would you mind rebasing or resolving the conflicts?

@timtebeek timtebeek added the recipe Recipe requested label Jul 9, 2024
BhavanaPidapa and others added 2 commits July 9, 2024 12:20
…s.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BhavanaPidapa ! I've pushed a few minor changes, but otherwise good to go.

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After spotting some last minute duplication I've now replaced the old specific recipe we had for a single class with the generic ChangePackage recipe added here.

@timtebeek timtebeek merged commit 78159d1 into openrewrite:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants