refactor: Common static analysis issues

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.CommonStaticAnalysis?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
openrewrite · Dec 6, 2023 · fb4c00d · fb4c00d
1 parent c1c0ebd
commit fb4c00d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/org/openrewrite/java/micronaut/AddSnakeYamlDependencyIfNeeded.java b/src/main/java/org/openrewrite/java/micronaut/AddSnakeYamlDependencyIfNeeded.java
@@ -29,7 +29,7 @@ public class AddSnakeYamlDependencyIfNeeded extends ScanningRecipe<AddSnakeYamlD
     private final List<Recipe> recipeList = new ArrayList<>();
 
     static class YamlAccumulator {
-        boolean usingYamlConfig = false;
+        boolean usingYamlConfig;
     }
 
     public AddSnakeYamlDependencyIfNeeded() {

diff --git a/src/main/java/org/openrewrite/java/micronaut/AddTestResourcesClientDependencyIfNeeded.java b/src/main/java/org/openrewrite/java/micronaut/AddTestResourcesClientDependencyIfNeeded.java
@@ -31,7 +31,7 @@ public class AddTestResourcesClientDependencyIfNeeded extends ScanningRecipe<Add
     private final List<Recipe> recipeList = new ArrayList<>();
 
     static class Scanned {
-        boolean isTestResourcesEnabled = false;
+        boolean isTestResourcesEnabled;
     }
 
     public AddTestResourcesClientDependencyIfNeeded() {

diff --git a/src/main/java/org/openrewrite/java/micronaut/MicronautVersionHelper.java b/src/main/java/org/openrewrite/java/micronaut/MicronautVersionHelper.java
@@ -48,7 +48,7 @@ public static Optional<String> getNewerVersion(String versionPattern, String cur
         VersionComparator versionComparator = Semver.validate(versionPattern, null).getValue();
         assert versionComparator != null;
 
-        String groupId = Semver.majorVersion(versionPattern).equals("4") ? V4_GROUP_ID : GROUP_ID;
+        String groupId = "4".equals(Semver.majorVersion(versionPattern)) ? V4_GROUP_ID : GROUP_ID;
 
         MavenMetadata mavenMetadata = new MavenPomDownloader(emptyMap(), ctx)
                 .downloadMetadata(new GroupArtifact(groupId, ARTIFACT_ID), null, emptyList());

diff --git a/src/main/java/org/openrewrite/java/micronaut/UpdateSecurityYamlIfNeeded.java b/src/main/java/org/openrewrite/java/micronaut/UpdateSecurityYamlIfNeeded.java
@@ -42,7 +42,7 @@ public class UpdateSecurityYamlIfNeeded extends Recipe {
             "bearer:\n" +
             "  enabled:";
 
-    private final String TOKEN_PATH = "$.micronaut.security.token";
+    private static final String TOKEN_PATH = "$.micronaut.security.token";
 
     @Override
     public String getDisplayName() {

diff --git a/src/test/java/org/openrewrite/java/micronaut/MicronautRewriteTestVersions.java b/src/test/java/org/openrewrite/java/micronaut/MicronautRewriteTestVersions.java
@@ -19,7 +19,7 @@
 import org.openrewrite.InMemoryExecutionContext;
 import org.openrewrite.maven.MavenDownloadingException;
 
-public class MicronautRewriteTestVersions {
+public final class MicronautRewriteTestVersions {
     private static final String MN_2_VERSION;
     private static final String MN_3_VERSION;
     private static final String MN_4_VERSION;