Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Jelly files should be considered text files. #897

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Nov 20, 2024

What's Changed?

I have added a configuration to ensure that Jelly files (with .jelly extension) are properly recognized as text files. Currently, *.jelly files are treated as quarks (unidentified files).

Motivation

This change was prompted by the recent release of the AddJellyXmlDeclaration recipe. The recipe requires the additionalPlainTextMasks option to function correctly. Here's the complete Maven command:

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
    -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-jenkins:RELEASE \
    -Drewrite.activeRecipes=org.openrewrite.jenkins.AddJellyXmlDeclaration \
    -Drewrite.exportDatatables=true \
    -Drewrite.additionalPlainTextMasks=**/*.jelly

As discussed here, this modification should address the current issue.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@gounthar gounthar marked this pull request as ready for review November 20, 2024 10:00
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initiative here!

timtebeek added a commit to openrewrite/rewrite-gradle-plugin that referenced this pull request Nov 20, 2024
@timtebeek
Copy link
Contributor

Made the matching change in the Gradle plugin as well: openrewrite/rewrite-gradle-plugin@df04e6d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants