Accept any directories under src in ResourceParser
#868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
changed the title
src in ResourceParser
timtebeek
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Nice and measured improvement here @marcel-gepardec , thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added accepted directories to accept all recursive directories within "src".
What's changed?
Previously it only checked whether the path contains one of the DEFAULT_IGNORED_DIRECTORIES.
Now it checks whether the path also contains one of the DEFAULT_ACCEPTED_DIRECTORIES.
Now "src" will return false almost instantly and will not return true although there could be a build or out folder within the "src" folder.
What's your motivation?
Motivation was the open Issue #850. This is a fix to this issue and maybe a feature to be considered.