Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse inline checkstyle config from maven-checkstyle-plugin #768

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

tobli
Copy link
Contributor

@tobli tobli commented Apr 7, 2024

What's changed?

Inline checkstyle config from maven-checkstyle-plugin can now be parsed, in addition to reading file references from the configLocation tag.

What's your motivation?

Support more of the various config options that exist for maven-checkstyle-plugin, to capture more style instructions that exist in existing codebases.

Anything in particular you'd like reviewers to focus on?

I didn't think of an obvious positive test case, but I'm happy to take suggestions. For now, just look for the absence of parsing errors.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review April 23, 2024 17:28
@timtebeek timtebeek added the enhancement New feature or request label Apr 23, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working out what's required to parse inline config; nice to be able to cover this variant as well!

@timtebeek timtebeek merged commit af5fb72 into openrewrite:main Apr 24, 2024
1 check passed
@tobli
Copy link
Contributor Author

tobli commented Apr 24, 2024

Thanks for working out what's required to parse inline config; nice to be able to cover this variant as well!

My follow up is parsing check style files from plugin dependency jars. That requires some more refactoring, but with this the diff is smaller. I can post a rough draft PR soon for early feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants