Adding a logging resolution event listener #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammachado
force-pushed
the
logging-resolution-listener
branch
from
5b9c1d7 to
e0a8493
Compare
ammachado
changed the title
timtebeek
reviewed
Jan 31, 2024
src/main/java/org/openrewrite/maven/MavenLoggingResolutionEventListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/maven/MavenLoggingResolutionEventListener.java
Outdated
Show resolved
Hide resolved
…tListener.java Co-authored-by: Tim te Beek <[email protected]>
|
Let me know when you consider this ready to review; as it's still marked as a draft. |
timtebeek
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Great to see this @ammachado ; After trying it out I've minimized the logged messages a bit, as in particular the resolved properties made debug mode unusable. Rather than trace I figured only keep the most valuable ones related to download success/failure and failure to access repositories.
Hope you agree!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a logging
ResolutionListeneronMavenMojoProjectParser.What's your motivation?
Identify maven resolution issues (#703).
Anything in particular you'd like reviewers to focus on?
No
Anyone you would like to review specifically?
No
Have you considered any alternatives or workarounds?
Current maven debug output is not helpful regarding the plugin dependency resolution errors.
Any additional context
No
Checklist