Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delaying execution to the end of multi-module project #720

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Delaying execution to the end of multi-module project #720

merged 1 commit into from
Jan 22, 2024

Conversation

philippe-granet
Copy link
Contributor

What's changed?

Delaying execution to the end of multi-module project

What's your motivation?

Fix #719

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative here @philippe-granet ! I like how you've both fixed a bug and made the code more expressive by introducing a shared method.

I take it you've tried this out in parallel and it worked well? Any feedback there would be appreciated!

@timtebeek timtebeek merged commit a6161cb into openrewrite:main Jan 22, 2024
1 check passed
@philippe-granet
Copy link
Contributor Author

@timtebeek yes I tested it before on several projects, with maven parallel buid and it works like a charm !
Thanks for making openrewrite Opensource, it's a awesome tool ❤️

@timtebeek
Copy link
Contributor

Glad to hear that works well! And thank you for helping improve it in your various contributions; really nice to see. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Delaying execution to the end of multi-module project
2 participants