Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Netty to 4.1.94 & Rsocket to 1.1.4 #586

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Bump Netty to 4.1.94 & Rsocket to 1.1.4 #586

merged 1 commit into from
Jun 28, 2023

Conversation

timtebeek
Copy link
Contributor

What's changed?

Netty to 4.1.94
Rsocket to 1.1.4

What's your motivation?

Vulnerability report.

Any additional context

Netty 4.1.94.Final released on 19-Jun-23
Netty 4.1.93.Final released on 25-May-23
Netty 4.1.92.Final released on 25-Apr-23
Netty 4.1.91.Final released on 03-Apr-23
Netty 4.1.90.Final released on 14-Mar-23
https://github.com/rsocket/rsocket-java/releases/tag/1.1.4

@timtebeek timtebeek self-assigned this Jun 28, 2023
@timtebeek timtebeek added the dependencies Pull requests that update a dependency file label Jun 28, 2023
<dependency>
<groupId>io.rsocket</groupId>
<artifactId>rsocket-bom</artifactId>
<version>${rsocket.version}</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added instead of duplicated version down below.

@@ -103,7 +104,7 @@
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>5.9.2</version>
<version>5.9.3</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured not noteworthy, but worthwhile.

Comment on lines +79 to +81
<netty.version>4.1.94.Final</netty.version>
<rocksdbjni.version>8.0.0</rocksdbjni.version>
<rsocket.version>1.1.4</rsocket.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use Netty through rsocket, hence why we're updating these in tandem.

@timtebeek timtebeek requested a review from rpau June 28, 2023 13:55
@sambsnyd sambsnyd merged commit 5ab0b1c into main Jun 28, 2023
@sambsnyd sambsnyd deleted the tim/netty_4.1.x branch June 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants