-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenRewrite 8.0 upgrade #549
Conversation
9fc0f28
to
6d8d1d8
Compare
# Conflicts: # pom.xml
The `JavaSourceSet#classpath` should only contain the types which were available when the sources were originally compiled, minus the types from the sources themselves.
On 7.x developers can run a lot of static analysis recipes without adding any dependencies, with a single Maven command. For instance:
In 8.x a lot of these clean up recipes have been moved to rewrite-static-analysis, a separate module that requires an explicit dependency. Would we want to include that dependency by default here to keep that option? |
Could make sense. But then we would probably have to create a new release of the Maven plugin every time we release |
Guess you're right; I think if we don't do anything the docs will start to generate new code snippets that include the dependency, so we can start with that and see if we get any feedback. Or have the plugin start to use the recipe-bom, with optional cascading releases on that. 🤔 |
No description provided.