Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenRewrite 8.0 upgrade #549

Merged
merged 10 commits into from
May 31, 2023
Merged

OpenRewrite 8.0 upgrade #549

merged 10 commits into from
May 31, 2023

Conversation

knutwannheden
Copy link
Contributor

No description provided.

The `JavaSourceSet#classpath` should only contain the types which were available when the sources were originally compiled, minus the types from the sources themselves.
@timtebeek
Copy link
Contributor

On 7.x developers can run a lot of static analysis recipes without adding any dependencies, with a single Maven command. For instance:

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.activeRecipes=org.openrewrite.java.cleanup.EqualsAvoidsNull

In 8.x a lot of these clean up recipes have been moved to rewrite-static-analysis, a separate module that requires an explicit dependency. Would we want to include that dependency by default here to keep that option?

@knutwannheden
Copy link
Contributor Author

Would we want to include that dependency by default here to keep that option?

Could make sense. But then we would probably have to create a new release of the Maven plugin every time we release rewrite-static-analysis as well, as otherwise the instruction from the docs won't work. Right?

@timtebeek
Copy link
Contributor

Guess you're right; I think if we don't do anything the docs will start to generate new code snippets that include the dependency, so we can start with that and see if we get any feedback. Or have the plugin start to use the recipe-bom, with optional cascading releases on that. 🤔

@kunli2 kunli2 merged commit 0ddc018 into main May 31, 2023
@kunli2 kunli2 deleted the large-repositories branch May 31, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants