Skip to content

Commit

Permalink
Allow the use of Java 17 in tests (#604)
Browse files Browse the repository at this point in the history
* Allow the use of Java 17 in tests

* Drop reference to outdated bootstrap from README.md
  • Loading branch information
timtebeek authored Jul 26, 2023
1 parent 035b1c0 commit 376b4c6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 33 deletions.
8 changes: 0 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,6 @@ All tests can be run from the command line using:

If you're looking for more information on the output from a test, try checking the `target/maven-it/**/*IT/**` directory contents after running the tests. It will contain the project state output, including maven logs, etc. Check the [`Integration Testing Framework Users Guide`](https://khmarbaise.github.io/maven-it-extension/itf-documentation/usersguide/usersguide.html) for information, too. It's good.

### Using this plugin against itself

The `pom.xml` file contains a `bootstrap` profile to use the `rewrite-maven-plugin` against itself (it's a helpful plugin, why not use it to help develop itself?).

```sh
./mvnw -Pbootstrap rewrite:dryRun
```

## Contributing

We appreciate all types of contributions. See the [contributing guide](https://github.com/openrewrite/.github/blob/main/CONTRIBUTING.md) for detailed instructions on how to get started.
Expand Down
28 changes: 3 additions & 25 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>1.8</java.version>

<maven.compiler.testSource>17</maven.compiler.testSource>
<maven.compiler.testTarget>17</maven.compiler.testTarget>

<!-- dependencies and plugins -->
<jackson-bom.version>2.15.2</jackson-bom.version>
<netty.version>4.1.94.Final</netty.version>
Expand Down Expand Up @@ -304,7 +307,6 @@

<!-- JUnit Jupiter, and using itf-jupiter-extension to get itf support for executing everything as Maven tests -->
<dependency>

<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
Expand All @@ -326,7 +328,6 @@
<scope>test</scope>
</dependency>
<!-- Using assertj as well as custom assertions of AssertJ provided by itf-assertj -->
<!-- If you don’t want to use AssertJ as assertion framework you can omit them both -->
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
Expand Down Expand Up @@ -596,29 +597,6 @@
</developerConnectionUrl>
</properties>
</profile>
<profile>
<!-- for applying versions of the rewrite-maven-plugin against itself. -->
<!-- if you wanted to try using the plugin with changes made locally, you could run ./mvnw install, then set the plugin version below to the current version of the plugin being developed. -->
<!-- ./mvnw -Pbootstrap rewrite:help -->
<id>bootstrap</id>
<build>
<plugins>
<plugin>
<groupId>org.openrewrite.maven</groupId>
<artifactId>rewrite-maven-plugin</artifactId>
<version>4.40.0</version>
<configuration>
<activeRecipes>
<recipe>org.openrewrite.java.format.AutoFormat</recipe>
</activeRecipes>
</configuration>
</plugin>
</plugins>
</build>
<properties>
<maven.test.skip>true</maven.test.skip>
</properties>
</profile>
</profiles>

<repositories>
Expand Down

0 comments on commit 376b4c6

Please sign in to comment.