Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testcase to validate switch cases in SystemErrToLogging #197

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Add testcase to validate switch cases in SystemErrToLogging #197

merged 3 commits into from
Dec 4, 2024

Conversation

Laurens-W
Copy link
Contributor

@Laurens-W Laurens-W commented Dec 4, 2024 •
edited by timtebeek
Loading

What's changed?

Add testcase to validate switch cases in SystemErrToLogging

What's your motivation?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W added the bug Something isn't working label Dec 4, 2024
@Laurens-W Laurens-W requested a review from timtebeek December 4, 2024 19:07
@Laurens-W Laurens-W self-assigned this Dec 4, 2024
timtebeek
timtebeek approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see! Approved already; let's see if this indeed fixes the issue

@timtebeek timtebeek merged commit 799c19f into main Dec 4, 2024
2 checks passed
@timtebeek timtebeek deleted the validate-switch-template branch December 4, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@Laurens-W Laurens-W

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SystemErrToLogging recipe doesn't work when method invocation occurs in a swtich-case block in some cases.
2 participants
@Laurens-W @timtebeek