Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SSO token rule and updated readme #6

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Fixed SSO token rule and updated readme #6

merged 3 commits into from
Aug 17, 2023

Conversation

cjobinabo
Copy link
Contributor

@cjobinabo cjobinabo commented Aug 17, 2023

What's changed?

This pull request addresses an issue found with the SSO token recipe where the wrong qualified class was provided. I've also made some updates to the README.md.

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

@cjobinabo cjobinabo self-assigned this Aug 17, 2023
@timtebeek timtebeek added bug Something isn't working documentation Improvements or additions to documentation labels Aug 17, 2023
@cjobinabo cjobinabo merged commit 679583e into main Aug 17, 2023
@cjobinabo cjobinabo deleted the some-fixes branch August 17, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants