Use OmitParentheses marker for new operation without parentheses (#182)

Co-authored-by: Andrii Rodionov <[email protected]>
openrewrite · Dec 30, 2024 · e025613 · e025613
1 parent 54b0dca
commit e025613
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 4 deletions.
diff --git a/openrewrite/src/java/markers.ts b/openrewrite/src/java/markers.ts
@@ -46,3 +46,21 @@ export class TrailingComma implements Marker {
         return suffix == this._suffix ? this : new TrailingComma(this._id, suffix);
     }
 }
+
+@LstType("org.openrewrite.java.marker.OmitParentheses")
+export class OmitParentheses implements Marker {
+    [MarkerSymbol] = true;
+    private readonly _id: UUID;
+
+    constructor(id: UUID) {
+        this._id = id;
+    }
+
+    get id() {
+        return this._id;
+    }
+
+    withId(id: UUID): OmitParentheses {
+        return id == this._id ? this : new OmitParentheses(id);
+    }
+}
diff --git a/openrewrite/src/javascript/parser.ts b/openrewrite/src/javascript/parser.ts
@@ -1945,7 +1945,7 @@ export class JavaScriptParserVisitor {
                 this.mapTypeArguments(this.prefix(this.findChildNode(node, ts.SyntaxKind.LessThanToken)!), node.typeArguments),
                 null
             ): new TypeTreeExpression(randomId(), Space.EMPTY, Markers.EMPTY, this.visit(node.expression)),
-            this.mapCommaSeparatedList(this.getParameterListNodes(node)),
+            node.arguments ? this.mapCommaSeparatedList(this.getParameterListNodes(node)) : JContainer.empty<J.Expression>().withMarkers(Markers.build([(new J.OmitParentheses(randomId()))])),
             null,
             this.mapMethodType(node)
         );

diff --git a/openrewrite/test/javascript/parser/call.test.ts b/openrewrite/test/javascript/parser/call.test.ts
@@ -157,12 +157,12 @@ describe('call mapping', () => {
     });
 
     // need a way to distinguish new class calls with empty braces and without braces
-    test.skip('call new expression without braces', () => {
+    test('call new expression without braces', () => {
         rewriteRun(
             //language=typescript
             typeScript(`
                 var d = (new Date).getTime()
-                // use marker omit
+                const intType = new arrow.Uint32
             `)
         );
     });

diff --git a/rewrite-javascript/src/main/java/org/openrewrite/javascript/internal/JavaScriptPrinter.java b/rewrite-javascript/src/main/java/org/openrewrite/javascript/internal/JavaScriptPrinter.java
@@ -20,6 +20,7 @@
 import org.openrewrite.PrintOutputCapture;
 import org.openrewrite.Tree;
 import org.openrewrite.java.JavaPrinter;
+import org.openrewrite.java.marker.OmitParentheses;
 import org.openrewrite.java.marker.Semicolon;
 import org.openrewrite.java.marker.TrailingComma;
 import org.openrewrite.java.tree.*;
@@ -1275,7 +1276,9 @@ public J visitNewClass(J.NewClass newClass, PrintOutputCapture<P> p) {
             if (newClass.getClazz() != null) {
                 p.append("new");
                 visit(newClass.getClazz(), p);
-                visitContainer("(", newClass.getPadding().getArguments(), JContainer.Location.NEW_CLASS_ARGUMENTS, ",", ")", p);
+                if (!newClass.getPadding().getArguments().getMarkers().findFirst(OmitParentheses.class).isPresent()) {
+                    visitContainer("(", newClass.getPadding().getArguments(), JContainer.Location.NEW_CLASS_ARGUMENTS, ",", ")", p);
+                }
             }
             visit(newClass.getBody(), p);
             afterSyntax(newClass, p);