Simplify Plugins approach to adding dependencies so that it no longer uses a hidden detached configuration.

[arlaneenalra]

What's changed?

Removed dependency copying out of the rewrite configuration to a hidden detached one.

What's your motivation?

We have internal tooling that relies on being able to attach to configurations with a beforeResolve hook override dependencies and provide centralized dependency versioning. With the detached configuration there is not way to attach the hook and dependency resolution fails. By removing the detached configuration in favor of the rewrite configuration we should be able to use normal hooks as expected.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

We've attempted several approaches without modifying the existing plugin but each has run into subtle problems.

• Resolving our internal dependencies first (currently a library of internal recipes) and injecting the resovled files as dependencies. - Lead to duplicated jars on the classpath.
• Replacing the dependencies provider externally with one we can control. - There's no way to get a list of the dependencies the plugin adds without reflectively changing access levels, other forms of nastiness, or repeating the first problem but from the opposite side.

Any additional context

Checklist

• [ ] I've added unit tests to cover both positive and negative cases Existing test cases already cover the behavior and the expected behavior should not change.
• [/] I've read and applied the recipe conventions and best practices
• [/] I've used the IntelliJ IDEA auto-formatter on affected files

[arlaneenalra]

Just realized this is running knownRewriteDependencies too soon ... I'll need to fix that.

[arlaneenalra]

Ok, switched to beforeResolve instead of addLater That lombok issue is still present from the mainline. Not sure what to do with that.

[arlaneenalra]

Ping, What are the next steps here?

[shanman190]

@arlaneenalra, right now it appears that the same failing test on main is causing you some grief here. Just to confirm, it is just the lombok test that fails with the testGradle4 task? If so, we can probably go ahead and get this merged and afterwards fix the test. I think Sam was planning to rework the lombok setup very soon, so this test would probably get updated due to that.

[arlaneenalra]

@arlaneenalra, right now it appears that the same failing test on main is causing you some grief here. Just to confirm, it is just the lombok test that fails with the testGradle4 task? If so, we can probably go ahead and get this merged and afterwards fix the test. I think Sam was planning to rework the lombok setup very soon, so this test would probably get updated due to that.

I'm pretty sure that particular test is actually skipped when using testGradle4. Yeah I just verified, it get's skipped for that task.

RewriteRunTest > lombokTypeAttribution(File) SKIPPED

Probably because of

rewrite-gradle-plugin/plugin/src/test/kotlin/org/openrewrite/gradle/RewriteRunTest.kt

Line 1503 in 95e550b

@EnabledOnJre(JRE.JAVA_17)

It is the only test to fail for the generic test and the ci build from what I can tell.

[timtebeek]

hi @arlaneenalra ; thanks again! Your change is now available through
https://github.com/openrewrite/rewrite-gradle-plugin/releases/tag/v6.28.0

Hope that helps you there!

[arlaneenalra]

It should, I'm on pto right now, but I should put this to use shory after the holiday.

…

On Wed, Nov 27, 2024, 15:48 Tim te Beek ***@***.***> wrote: hi @arlaneenalra <https://github.com/arlaneenalra> ; thanks again! Your change is now available through https://github.com/openrewrite/rewrite-gradle-plugin/releases/tag/v6.28.0 Hope that helps you there! — Reply to this email directly, view it on GitHub <#345 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACYAP6APSA5W4KWFTZMMKD2CY437AVCNFSM6AAAAABRZ7R5HSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBUHAZTIMZYHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>