Look for ParseExceptionResult marker instead of instanceof ParserError #316
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Previously we looked at
source instanceof ParseError, but there might be cases in the future where a file parsed correctly, but got assigned a marker for a different reason. Up to now that had been exclusive to Maven files, but figured it good to support here as well.What's your motivation?
Over on the Maven side we saw files silently having error markers, with no indication that they failed to resolve. This ensures if that happens for files that show in the Gradle side of things then we are ready to show those here as well.
Any additional context