Add ability to export dataTables #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwalker
commented
Jul 19, 2024
| @@ -1255,6 +1257,14 @@ protected ResultsContainer listResults(ExecutionContext ctx) { | |||
|
|
|||
| logger.lifecycle("All sources parsed, running active recipes: {}", String.join(", ", getActiveRecipes())); | |||
| RecipeRun recipeRun = recipe.run(new InMemoryLargeSourceSet(sourceFiles), ctx); | |||
|
|
|||
| if (extension.isExportDatatables()) { | |||
There was a problem hiding this comment.
This does exactly what the maven plugin does.
|
Thanks a lot for closing the gap here. Indeed seems like a mostly straightforward add with most functionality in core. I'll take a closer look after the weekend, but suspect that we should be able to add this pretty soon next week |
timtebeek
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added the ability to export data tables.
What's your motivation?
I was reading about them in the docs and found that they were only implemented in maven and there was a request to add them to the gradle plugin.
I did see that this open issue that talks about adding some configuration that would allow you more control over turning certain csv exports on or off. From a cursory look, it seems like I might have to change rewrite-core for that to work. I'm not opposed to doing that, but I thought I'd create this PR to get thoughts before moving too far forward.
I did not add any tests yet either. I'll be more than happy to update this to a prod-ready state.
I added to the
RewriteExtension:It defaults to false.
Here's a screenshot of the cvs file output:
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist