-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple SDKs and rebrand to rewrite-feature-flags #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/java/org/openrewrite/featureflags/RemoveBooleanFlagTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/featureflags/openfeature/RemoveGetBooleanValueTest.java
Outdated
Show resolved
Hide resolved
shanman190
reviewed
Aug 5, 2024
src/main/java/org/openrewrite/featureflags/FindFeatureFlag.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/featureflags/launchdarkly/ChangeVariationDefaultTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/featureflags/launchdarkly/MigrateUserToContextTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/featureflags/launchdarkly/RemoveBoolVariationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/featureflags/launchdarkly/search/FindFeatureFlagTest.java
Outdated
Show resolved
Hide resolved
This also will close #6 as the implementation was included here. |
shanman190
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Rename module to rewrite-feature-flags.
Change packages to match new structure.
Add support for
What's your motivation?
Become a more general wrapper for other SDKs, similar to what we've seen with
https://github.com/openrewrite/rewrite-logging-frameworks
https://github.com/openrewrite/rewrite-testing-frameworks
Fixes Rebrand recipe module to rewrite-feature-flags #26
Fixes Support the OpenFeature Provider #6
Anything in particular you'd like reviewers to focus on?
Any concerns with the package change for existing recipes?
If needed we once-upon-a-time had a recipe to fix renames.
Anyone you would like to review specifically?
@shanman190
Have you considered any alternatives or workarounds?
Separate git repository per vendor seemed too heavy handed to maintain.
Separate submodules per vendor seemed too early, even if that leads to better classpath separation.
Briefly explored Togglz, but since that uses Enums it would need a dedicated recipe implementation.
Any additional context