Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple SDKs and rebrand to rewrite-feature-flags #27

Merged
merged 16 commits into from
Aug 5, 2024

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented Aug 4, 2024

What's changed?

Rename module to rewrite-feature-flags.
Change packages to match new structure.
Add support for

  • FF4j
  • OpenFeature
  • Unleash

What's your motivation?

Become a more general wrapper for other SDKs, similar to what we've seen with

Anything in particular you'd like reviewers to focus on?

Any concerns with the package change for existing recipes?
If needed we once-upon-a-time had a recipe to fix renames.

Anyone you would like to review specifically?

@shanman190

Have you considered any alternatives or workarounds?

Separate git repository per vendor seemed too heavy handed to maintain.
Separate submodules per vendor seemed too early, even if that leads to better classpath separation.
Briefly explored Togglz, but since that uses Enums it would need a dedicated recipe implementation.

Any additional context

@timtebeek timtebeek added enhancement New feature or request recipe labels Aug 4, 2024
@timtebeek timtebeek self-assigned this Aug 4, 2024
@timtebeek timtebeek marked this pull request as ready for review August 5, 2024 21:34
@shanman190
Copy link
Collaborator

This also will close #6 as the implementation was included here.

@shanman190 shanman190 merged commit 13d2c9b into main Aug 5, 2024
2 checks passed
@shanman190 shanman190 deleted the support-multiple-sdks branch August 5, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request recipe
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rebrand recipe module to rewrite-feature-flags Support the OpenFeature Provider
2 participants