Use new ConstantFold.findConstantExpr
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLLeitschuh
force-pushed
the
improve/JLL/use-findConstantExpr
branch
from
3e58e85 to
992bde8
Compare
|
Great to see this simplification! Note to self that we can likely use the same for RemoveBoolVariation and ChangeVariationDefault. |
Signed-off-by: Jonathan Leitschuh <[email protected]>
JLLeitschuh
force-pushed
the
improve/JLL/use-findConstantExpr
branch
from
992bde8 to
f336731
Compare
|
Thanks for taking on those additional cases as well! Great how we can now match so much more with a convenient API. |
|
Yea, |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonathan Leitschuh [email protected]