Add recipe to change variation default #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanman190
approved these changes
Dec 2, 2023
src/main/java/org/openrewrite/launchdarkly/ChangeVariationDefault.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/launchdarkly/ChangeVariationDefault.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/launchdarkly/ChangeVariationDefaultTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/launchdarkly/ChangeVariationDefaultTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Shannon Pamperl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add recipe to change
booleanVariation,stringVariation,doubleVariationandintVariationdefault values.What's your motivation?
Allow folks to flip the default value to a new value as a feature matures, such that the right value is selected when it can not be retrieved.
Fixes #13
Have you considered any alternatives or workarounds?
Again, opted not to use
FindFeatureFlagjust yet, while further test data flow analysis on larger projects.Any additional context
Folks that want store their feature keys in constants might want to first run this recipe to phase that out, ahead of removal.
https://docs.openrewrite.org/recipes/java/replaceconstant