Add CSharp implementation of proposed NamingService
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is requested from a Cs.CompilationUnit
Laurens-W
force-pushed
the
csharp-naming-service
branch
from
6d21307 to
1c2cbce
Compare
timtebeek
reviewed
Dec 3, 2024
Comment on lines
+25
to
+26
| private static final Pattern STANDARD_METHOD_NAME = Pattern.compile("^[A-Z][a-zA-Z0-9]*$"); | ||
| private static final Pattern SNAKE_CASE = Pattern.compile("^[a-zA-Z0-9]+_\\w+$"); |
There was a problem hiding this comment.
We made some changes in openrewrite/rewrite#4725 ; might be best to similarly test here that we use C# expected naming from a few valid but odd inputs in a unit test.
timtebeek
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add CSharp implementation of proposed
NamingServiceAnyone you would like to review specifically?
@timtebeek @OlegDokuka @knutwannheden
Checklist