Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move org.openrewrite.java.apache.httpclient4.MigrateDefaultHttpClient to rewrite-apache #1

Closed
JLLeitschuh opened this issue Feb 14, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@JLLeitschuh
Copy link
Contributor

What problem are you trying to solve?

org.openrewrite.java.apache.httpclient4.MigrateDefaultHttpClient seems to be in the wrong place as it isn't related to Spring.

Describe the solution you'd like

It would make sense to move the org.openrewrite.java.apache.httpclient4.MigrateDefaultHttpClient to a dedicated rewrite-apache package.

@JLLeitschuh JLLeitschuh added the enhancement New feature or request label Feb 14, 2024
@timtebeek
Copy link
Contributor

Hi! Yes I think you're right; We started out here as it's a requirement for the Spring migration, but by no means exclusive to it. We've similarly split off rewrite-hibernate and rewrite-openapi in the past, and this feels like a natural extension to that. We could then also move the Apache commons recipes that are now in rewrite-migrate-java into rewrite-apache.

I've gone ahead and created https://github.com/openrewrite/rewrite-apache ; Now all I need is a bit of time to wrestle with Git to keep authorship of the original files when moved into there, such that the docs will show all involved.

@timtebeek timtebeek transferred this issue from openrewrite/rewrite-spring Feb 17, 2024
@timtebeek timtebeek moved this to Backlog in OpenRewrite Feb 17, 2024
@timtebeek
Copy link
Contributor

Completed this migration using this reference, and moving the paths to match the new target location.

@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenRewrite Mar 2, 2024
@timtebeek timtebeek self-assigned this Mar 2, 2024
@timtebeek
Copy link
Contributor

timtebeek commented Mar 2, 2024

Still to do:

  • do an initial release and include with rewrite-recipe-bom & release bot
  • update rewrite-docs and rewrite-recipe-markdown-generator
  • remove references from rewrite-spring and rewrite-migrate-java
  • run weekly internal vulnerability scans against rewrite-apache
  • deploy to app.moderne.io & possibly others
  • add quick regex recipe for folks that want to adopt the new recipe paths

@timtebeek timtebeek reopened this Mar 2, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in OpenRewrite Mar 2, 2024
timtebeek added a commit to openrewrite/rewrite-migrate-java that referenced this issue Mar 2, 2024
timtebeek added a commit to openrewrite/rewrite-spring that referenced this issue Mar 2, 2024
timtebeek added a commit to openrewrite/rewrite-spring that referenced this issue Mar 8, 2024
timtebeek added a commit to openrewrite/rewrite-migrate-java that referenced this issue Mar 8, 2024
* Drop rewrite-apache recipes

openrewrite/rewrite-apache#1

* Restore UseMavenCompilerPluginReleaseConfigurationTest

* Restore UseMavenCompilerPluginReleaseConfigurationTest
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Mar 8, 2024
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants