Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Functional Java dependency #4

Merged
merged 1 commit into from
May 30, 2023
Merged

Move to Functional Java dependency #4

merged 1 commit into from
May 30, 2023

Conversation

JLLeitschuh
Copy link
Contributor

Signed-off-by: Jonathan Leitschuh [email protected]

What's changed?

What's your motivation?

Closes #1

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ auto-formatter on affected files
  • I've updated the documentation (if applicable)

@JLLeitschuh
Move to Functional Java dependency
8d85bad 
Signed-off-by: Jonathan Leitschuh <[email protected]>
knutwannheden
knutwannheden approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't know if anybody else wants to comment.

@JLLeitschuh JLLeitschuh merged commit d045117 into main May 30, 2023
@JLLeitschuh JLLeitschuh deleted the feat/JLL/convert-to-functional-java branch May 30, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden approved these changes

@sambsnyd sambsnyd Awaiting requested review from sambsnyd

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JLLeitschuh @knutwannheden