Add support for finding all values for VarAccess #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLLeitschuh
reviewed
Jul 20, 2023
Comment on lines
139
to
147
| new JavaIsoVisitor<List<Expr>>() { | ||
| @Override | ||
| public @Nullable J visit(@Nullable Tree tree, List<Expr> exprs, Cursor parent) { | ||
| if (tree instanceof J.FieldAccess) { | ||
| varAccess[0] = VarAccess.viewOf(new Cursor(parent, ((J.FieldAccess) tree).getName())); | ||
| } | ||
| return super.visit(tree, exprs, parent); | ||
| } | ||
| }.visit(assignment.getVariable(), exprs, getCursor()); |
There was a problem hiding this comment.
Suggested change
| new JavaIsoVisitor<List<Expr>>() { | |
| @Override | |
| public @Nullable J visit(@Nullable Tree tree, List<Expr> exprs, Cursor parent) { | |
| if (tree instanceof J.FieldAccess) { | |
| varAccess[0] = VarAccess.viewOf(new Cursor(parent, ((J.FieldAccess) tree).getName())); | |
| } | |
| return super.visit(tree, exprs, parent); | |
| } | |
| }.visit(assignment.getVariable(), exprs, getCursor()); | |
| new JavaIsoVisitor<Integer>() { | |
| @Override | |
| public J.FieldAccess visitFieldAccess(J.FieldAccess fieldAccess, Integer x) { | |
| varAccess[0] = VarAccess.viewOf(new Cursor(parent, fieldAccess.getName())); | |
| return super.visitFieldAccess(tree, x); | |
| } | |
| }.visit(assignment.getVariable(), 0, getCursor()); |
JLLeitschuh
reviewed
Jul 20, 2023
| @@ -110,6 +111,50 @@ public J visitIdentifier(J.Identifier ident, List<VarAccess> varAccesses) { | |||
| }.visit(scope.getValue(), varAccesses, scope.getParentOrThrow()); | |||
| return varAccesses; | |||
| } | |||
|
|
|||
| static Collection<Expr> findAllValues(Cursor scope, Variable variable) { | |||
There was a problem hiding this comment.
I don't think this method should live here (on this interface) since it's not being used to find instances of VarAccess unlike the method above. Also, I would call it findAssignedValues.
There was a problem hiding this comment.
Maybe create a package-private class called VariableUtil and put this method there?
JLLeitschuh
reviewed
Jul 20, 2023
Comment on lines
+127
to
+129
| if (methodDeclaration.getBody() == null) { | ||
| return Collections.emptySet(); | ||
| } |
JLLeitschuh
reviewed
Jul 20, 2023
There was a problem hiding this comment.
One more test I would verify as well
class Test {
int i = 1;
void test(int i) {
this.i = 2;
i = 3;
}
void test() {
this.i = 4;
int i = 5;
i = 6;
}
}
JLLeitschuh
suggested changes
Jul 20, 2023
src/main/java/org/openrewrite/analysis/trait/variable/VariableUtil.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findAllValuesmethod forVarAccessgetAssignedValue