feature: add bypass_if_checks method to ngx.resp #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hereby granted the copyright of the changes in this pull request to the authors of this lua-resty-core project. Signed-off-by: tzssangglass <[email protected]>
|
sister PR: openresty/lua-nginx-module#2401 |
oowl
reviewed
Mar 5, 2025
| if not r then | ||
| error("no request found") | ||
| end | ||
| return C.ngx_http_lua_ffi_bypass_if_checks(r) |
There was a problem hiding this comment.
I think we do not need any return value here.
There was a problem hiding this comment.
What about also removing the return NGX_OK;
in https://github.com/openresty/lua-nginx-module/pull/2401/files#diff-ea7694db95d4b4f2da2951cf882953a64e545494e6b9302cb9e80d0abf8f8fbbR4562?
spacewander
reviewed
Mar 6, 2025
| @@ -87,6 +88,14 @@ status with an optional reason. The `reason` should be a string. | |||
|
|
|||
| [Back to TOC](#table-of-contents) | |||
|
|
|||
| bypass_if_checks | |||
| ------------------ | |||
| **syntax:** *ngx_resp.bypass_if_checks()* | |||
There was a problem hiding this comment.
Need a blank line after it. And don't forget to add the [Back to TOC](#table-of-contents)
| Bypasses the conditional header checks as defined in RFC 9110 for the current request. | ||
| This method is useful when you need to skip validation of headers such as `If-Modified-Since`, | ||
| `If-None-Match`, `If-Range`, `If-Unmodified-Since`, and `If-Match`, allowing the response to | ||
| proceed without evaluating these conditions. |
There was a problem hiding this comment.
What about also writing down the Why? When people have to call this method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request to the authors of this lua-resty-core project.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-resty-core project.