added the fifth param for ngx.re.find() #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lancelijade This looks generally good except that I'd rename the "n" parameter to "nth" to be a bit clearer :) Also, we need to port this "nth" argument support to the ngx_lua core's ngx.re.find implementation too :) |
|
I'm tried to modify ngx_http_lua_regex.c , but cannot correctly added the fifth argument to that function. :( |
|
Heh, that is an evidence for the better hackability of the new FFI-based API in lua-resty-core ;) No worries. I can take care of that :) |
agentzh
added a commit
to openresty/lua-nginx-module
that referenced
this pull request
Nov 26, 2013
… control which submatch capture's indexes are returned. thanks Lance Li for the feature request in openresty/lua-resty-core#1.
agentzh
added a commit
that referenced
this pull request
Nov 27, 2013
…nce Li for the original patch in #1.
|
Already applied a modified version of your patch to master. Also added the corresponding support to the ngx_lua core. |
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 11, 2024
…r at function end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 1414245 (nginx) of user 1000 dumped core.
Stack trace of thread 1414245:
#0 0x00007ff596938285 __strlen_avx2 (libc.so.6 + 0x162285)
openresty#1 0x00007ff596f623d2 lj_cf_ffi_string (libluajit-5.1.so.2 + 0x523d2)
openresty#2 0x00007ff596f1bb4b lj_BC_FUNCC (libluajit-5.1.so.2 + 0xbb4b)
openresty#3 0x00007ff596f74223 lua_pcall (libluajit-5.1.so.2 + 0x64223)
openresty#4 0x00000000005044b7 n/a (/home/jiahao/work/org/lua-resty-core/work/nginx/sbin/nginx + 0x1044b7)
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 11, 2024
…r at function end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 1414245 (nginx) of user 1000 dumped core.
Stack trace of thread 1414245:
#0 0x00007ff596938285 __strlen_avx2 (libc.so.6 + 0x162285)
openresty#1 0x00007ff596f623d2 lj_cf_ffi_string (libluajit-5.1.so.2 + 0x523d2)
openresty#2 0x00007ff596f1bb4b lj_BC_FUNCC (libluajit-5.1.so.2 + 0xbb4b)
openresty#3 0x00007ff596f74223 lua_pcall (libluajit-5.1.so.2 + 0x64223)
openresty#4 0x00000000005044b7 n/a (/home/jiahao/work/org/lua-resty-core/work/nginx/sbin/nginx + 0x1044b7)
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 11, 2024
…ction end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 2199905 (nginx) of user 1000 dumped core.
Stack trace of thread 2199905:
#0 0x00007ffaf1e4b385 in OPENSSL_sk_num (st=st@entry=0xffffffff) at crypto/stack/stack.c:382
openresty#1 0x0000000000510aba in sk_X509_num (sk=0xffffffff) at /opt/ssl/include/openssl/x509.h:99
openresty#2 ngx_http_lua_ffi_ssl_verify_client (r=<optimized out>, client_certs=<optimized out>, trusted_certs=0xffffffff, depth=<optimized out>, err=0x0)
at /home/jiahao/work/org/lua-nginx-module/src/ngx_http_lua_ssl_certby.c:1588
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 11, 2024
…ction end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 2199905 (nginx) of user 1000 dumped core.
Stack trace of thread 2199905:
#0 0x00007ffaf1e4b385 in OPENSSL_sk_num (st=st@entry=0xffffffff) at crypto/stack/stack.c:382
openresty#1 0x0000000000510aba in sk_X509_num (sk=0xffffffff) at /opt/ssl/include/openssl/x509.h:99
openresty#2 ngx_http_lua_ffi_ssl_verify_client (r=<optimized out>, client_certs=<optimized out>, trusted_certs=0xffffffff, depth=<optimized out>, err=0x0)
at /home/jiahao/work/org/lua-nginx-module/src/ngx_http_lua_ssl_certby.c:1588
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 15, 2024
…r at function end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 1414245 (nginx) of user 1000 dumped core.
Stack trace of thread 1414245:
#0 0x00007ff596938285 __strlen_avx2 (libc.so.6 + 0x162285)
openresty#1 0x00007ff596f623d2 lj_cf_ffi_string (libluajit-5.1.so.2 + 0x523d2)
openresty#2 0x00007ff596f1bb4b lj_BC_FUNCC (libluajit-5.1.so.2 + 0xbb4b)
openresty#3 0x00007ff596f74223 lua_pcall (libluajit-5.1.so.2 + 0x64223)
openresty#4 0x00000000005044b7 n/a (/home/jiahao/work/org/lua-resty-core/work/nginx/sbin/nginx + 0x1044b7)
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 15, 2024
…ction end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 2199905 (nginx) of user 1000 dumped core.
Stack trace of thread 2199905:
#0 0x00007ffaf1e4b385 in OPENSSL_sk_num (st=st@entry=0xffffffff) at crypto/stack/stack.c:382
openresty#1 0x0000000000510aba in sk_X509_num (sk=0xffffffff) at /opt/ssl/include/openssl/x509.h:99
openresty#2 ngx_http_lua_ffi_ssl_verify_client (r=<optimized out>, client_certs=<optimized out>, trusted_certs=0xffffffff, depth=<optimized out>, err=0x0)
at /home/jiahao/work/org/lua-nginx-module/src/ngx_http_lua_ssl_certby.c:1588
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 30, 2024
…r at function end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 1414245 (nginx) of user 1000 dumped core.
Stack trace of thread 1414245:
#0 0x00007ff596938285 __strlen_avx2 (libc.so.6 + 0x162285)
openresty#1 0x00007ff596f623d2 lj_cf_ffi_string (libluajit-5.1.so.2 + 0x523d2)
openresty#2 0x00007ff596f1bb4b lj_BC_FUNCC (libluajit-5.1.so.2 + 0xbb4b)
openresty#3 0x00007ff596f74223 lua_pcall (libluajit-5.1.so.2 + 0x64223)
openresty#4 0x00000000005044b7 n/a (/home/jiahao/work/org/lua-resty-core/work/nginx/sbin/nginx + 0x1044b7)
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 30, 2024
…ction end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 2199905 (nginx) of user 1000 dumped core.
Stack trace of thread 2199905:
#0 0x00007ffaf1e4b385 in OPENSSL_sk_num (st=st@entry=0xffffffff) at crypto/stack/stack.c:382
openresty#1 0x0000000000510aba in sk_X509_num (sk=0xffffffff) at /opt/ssl/include/openssl/x509.h:99
openresty#2 ngx_http_lua_ffi_ssl_verify_client (r=<optimized out>, client_certs=<optimized out>, trusted_certs=0xffffffff, depth=<optimized out>, err=0x0)
at /home/jiahao/work/org/lua-nginx-module/src/ngx_http_lua_ssl_certby.c:1588
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to retrieve the n-th matched result's position