Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jn/gcp discovery improvements #579

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

kickroot
Copy link
Contributor

@kickroot kickroot commented Oct 3, 2023

Resolves PROD-8046
Resolves PROD-8041

Big Query:

 {
  "documentId" : "iQttP-XsPbGWGhNHVPk8Jw",
  "assetId" : "//bigquery.googleapis.com/projects/oss-discovery-test/datasets/oss_test_dataset",
  "resourceName" : "oss_test_dataset",
  "resourceId" : "//bigquery.googleapis.com/projects/oss-discovery-test/datasets/oss_test_dataset",
  "resourceType" : "GCP::BigQuery::Dataset",
...
}

Big Table:

 {
  "documentId" : "80tldNGTPUyMnk0LxhVs9w",
  "assetId" : "//bigtable.googleapis.com/projects/jason-758682/instances/jason-test-instance",
  "resourceName" : "jason-test-instance",
  "resourceId" : "//bigtable.googleapis.com/projects/jason-758682/instances/jason-test-instance",
  "resourceType" : "GCP::BigTable::Instance",
...
}

CloudSQL:

{
  "documentId" : "9hNMc5IdOtCsOGErA6OD8w",
  "assetId" : "//sqladmin.googleapis.com/projects/test-targets-347030/instances/cloud-sql-psql-inst",
  "resourceName" : "cloud-sql-psql-inst",
  "resourceId" : "//sqladmin.googleapis.com/projects/test-targets-347030/instances/cloud-sql-psql-inst",
  "resourceType" : "GCP::SQL::Instance",
  "region" : "us-west1",
...
}

@kickroot kickroot merged commit 91b0bc5 into main Oct 3, 2023
2 checks passed
@kickroot kickroot deleted the jn/gcp-discovery-improvements branch October 3, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants