Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: ADD: Add more robust build deploy workflow #54

Closed
wants to merge 2 commits into from

Conversation

mgrover1
Copy link
Contributor

@mgrover1 mgrover1 commented Aug 8, 2024

Closes #50

@kmuehlbauer - this runs myst execute which will actually run the notebooks 👍

Copy link

github-actions bot commented Aug 8, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 3fcbdd6
✅ Deployment Preview URL: https://openradar.github.io/erad2024/_preview/54

@kmuehlbauer
Copy link
Collaborator

@mgrover1 That's great!

To enable building the docker container in pullrequests, I've added build-book-pullrequest.yaml in #31. This is the failing CI run in this PR.

We might just fix the current build-book and build-book-pullrequest with the changes needed for getting the new myst workflow to re-enable the former workflows.

Also you'll need to fix the Py-ART error which surfaced here (get_cmap or something).

@mgrover1
Copy link
Contributor Author

mgrover1 commented Aug 8, 2024

Thanks @kmuehlbauer - I have a fix in for Py-ART 👍

ARM-DOE/pyart#1614

Waiting for CI to fully pass, then I will merge and release a new version!

@kmuehlbauer kmuehlbauer changed the title ADD: Add more robust build deploy workflow DO NOT MERGE: ADD: Add more robust build deploy workflow Aug 9, 2024
@kmuehlbauer
Copy link
Collaborator

Although this is green, it didn't test the new workflow. I'm working on a general fix, please do not merge!

@kmuehlbauer
Copy link
Collaborator

@mgrover1 We might have to revisit the approach from #57 and #61 to possibly move myst build from the container back to GH Actions. That we we would not need the additional dependency to nodejs within the container. We would only need to copy the created notebooks from inside the container to outside. We might even get the folder mapping correct to have inside==outside somehow.

I'm going to close this one now.

github-actions bot pushed a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New myst workflow does not run/render notebooks
2 participants